mvasin / react-div-100vh

A workaround for the '100vh' issue in mobile browsers

Home Page:https://react-div-100vh.vercel.app

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`as` prop not working

chrisvince opened this issue · comments

The as prop doesn't seem to be working correctly. It is rendering a div with an as attribute.

For example.

This

<Div100vh as="main">
    ...
</Div100vh>

Is rendering

<div as="main" style="height: 879px;">
    ...
</div>

this is also true of the dontReisze property — it works but gets passed through to the <div>, causing a warning from React.

Hi @chrisvince and @grrowl! I published react-div-100vh@0.4.0-beta.1 version of the package, which exports use100vh hook. I described it in the readme. Can please try it out and share if it works for you?

I released react-div-100vh@0.4.0 in which as prop is removed and use100vh hook is suggested to use for such cases, so I'm closing the issue. Please open a new issue if the new version doesn't work for you.