Quickfixsigns interacts poorly with :Glog command from fugitive

[Robin Munn]

The quickfixsigns plugin interacts poorly with the :Glog command from fugitive, wanting a line number that :Glog isn't supplying. This results in many lines of error messages, one per log entry. Even worse, those error messages are repeated every time you do a :cnext command (or equivalent mapping), making it painful to use fugitive.

https://gist.github.com/1714107 shows the results of running :Glog on the vimrc file from https://github.com/mutewinter/dot_vim.

Possible fixes might involve patching quickfixsigns not to complain when lnum = 0 -- the following patch to quickfixsigns seems to work:

diff --git a/plugin/quickfixsigns.vim b/plugin/quickfixsigns.vim
index 9215b34..79f384e 100755
--- a/plugin/quickfixsigns.vim
+++ b/plugin/quickfixsigns.vim
@@ -614,9 +614,9 @@ function! s:PlaceSign(class, sign, list) "{{{3
                     endif
                 endif
             else
-                echohl WarningMsg
-                echom "Quickfixsigns PlaceSign: Invalid lnum:" string(item)
-                echohl NONE
+                "echohl WarningMsg
+                "echom "Quickfixsigns PlaceSign: Invalid lnum:" string(item)
+                "echohl NONE
             endif
         endfor
     finally

Another fix would, of course, be removing quickfixsigns from the installed bundles list, though that might be overkill considering a 3-line patch is enough to solve the problem.

[Jeremy Mack]

Wow, thanks for such an awesome bug report. I would've run into this eventually and been sad. I submitted it as an issue to the quickfixsigns repo tomtom/quickfixsigns_vim#16.

[Jeremy Mack]

Fixed in tomtom/quickfixsigns_vim@ba13290.