Placment of the back button in Managed Software Centre
tbcahill opened this issue · comments
Within the ManagedSoftwareCentre.app when you navigate to a software category there is a back button in the top left corner. Half of the button is displayed over the banner/branding image - screenshot included:
Thanks for reporting, what OS/version are you running, and what banner image size/type is that? Is this easily reproducible in your environment across multiple devices? Does the issue also reproduce with the default banner? Is there more testing you'd be willing to do in order to see the range of either window sizes/positions or banners that the issue repeats under? I'm not sure munki/MSC claims to/can support just anything arbitrary after a certain point, as web/display frameworks can be messy (especially across OS versions) but when it's something that helps usability it's at least good to log as room for improvement, so as much as you'd be able to help out is appreciated. 👍
Hi Arubdesu,
Tested on my 13" M1 Macbook Air (macOS 14.1.2) using MSC 6.2.1.4599 with some custom banners (2316x400 px)
The issue happens on the built-in display regardless of the windows size. On my external display (2560x1080)the issue happens until you make the window size very wide.
I have also replicated the behavior on a VM (macOS 14.1.2) using the latest Munki version with no alterations - video attached.
Let me know if there are other tests I can do to assist.
Screen.Recording.2023-12-28.at.16.38.15.mov
More importantly: where should the button be, in your opinion?
I think it is good where it - if it's possible to stop the banner from sliding behind it when the window is resized below a certain width.
If it is easier to move it, then the best place would be below the banner, on the very left of the category bar.
I'd like to see a visual mockup of your suggestions. I'm having trouble picturing them in a way that would look good. I'd also like to point out the placement of the button in the App Store:
The Munki6dev branch (https://github.com/munki/munki/tree/Munki6dev) now has a tweak to the placement, appearance, and behavior of the back button that I think improves this minor issue.
Change here: 01a9d85
Like the corresponding button in the App Store app, it now has no visible border by default, and the background appears on mouseOver.
@gregneagle Thanks for working on this! Does this change prevent the banner image from overlapping behind the back button when the window is resized to a smaller size?
I saw no overlap when I tested my banner images.
Fix shipped with the 6.4.1 release.