Keep units together (€)

Question

strarsis opened this issue 6 years ago · comments

Issue Overview

Units should be kept together, '€' had been added to the list of units.

Have text on page that contains a price with a currency like "10 €" where its container should cause word breaking/hyphenation.
Notice that still a break occurs between the number (here "10") and the currency symbol (here "€").
The value and currency symbol are not wrapped into a wrapper element.
Adding the "€" to the list of units in wp-typography settings doesn't seem to prevent breaking.

WordPress 4.9.8, wp-typography 5.4.2, Gutenberg editor page.
Recent Chrome on Windows 10 Pro x64.

No breaking between value and unit symbol.

Prices with currency symbol (e.g. "10 €") are apparently not handled.

Der Mundschenk & Compagnie · Answer 1 · Mon Nov 26 2018 16:59:55 GMT+0800 (China Standard Time)

I'll look into it. Might be a problem with mundschenk-at/php-typography.

Der Mundschenk & Compagnie · Answer 2 · Thu Jan 24 2019 05:32:58 GMT+0800 (China Standard Time)

Uh-oh. There were a lot of issues with the unit spacing routines. Thanks for the report!

strarsis · Answer 3 · Thu Jan 24 2019 06:19:06 GMT+0800 (China Standard Time)

@mundschenk-at: It would be great if php-typography dependency could also be updated in wp-typography plugin and published.

Der Mundschenk & Compagnie · Answer 4 · Thu Jan 24 2019 06:23:58 GMT+0800 (China Standard Time)

Yes, of course, in due time :)