Giters

mundschenk-at / php-typography

A PHP library for improving your web typography.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

set_smart_diacritics is adding useless accented characters

romainpoirier opened this issue · comments

commented

Describe the bug

set_smart_diacritics is adding accented characters where this makes absolutely no sense, making this option useless.
né doesn't mean anything in French in a lot of context:

  • Il est né → He is born
  • Il ne veut pas → He does not want

While ne is most widely used, this setting is useless and must be disabled on French websites.

To reproduce

Steps to reproduce the behavior:

  1. Enable Typography with set_smart_diacritics set to true
  2. Write ne
  3. See text converted to né
commented

It's not suitable for French because the default language (see set_diacritic_language) is en-US. Currently, the only two languages supported are en-US and de-DE. If you can provide a suitable JSON file for French, I'll gladly include it.