XBus MODE B support: Want to contribute...but having some trouble how...
GruffyPuffy opened this issue · comments
Hi all!
Sorry if this is totally wrong place for this. Please remove it if so...
Well, I have a contribution for the baseflight project. It is an implementation of JR Propo's XBus serial receivers. Originally I did implement this by forking the "cleanflight" first and made a PR to that project. Then I started to work on the same contribution, but now for "baseflight" (as they differ a little). It was however not possible to create a new "fork" within GitHub as I had already forked the "cleanflight" (as this is a fork of "baseflight")... :(
So, I created a "copy" manually here on GitHub and did a branch called "xbus" and made a PR to my own repo.
Is it possible to send this to anyone manually as it seems impossible to have two different forks with the same base project as I tried? The private message function has been removed from github a few years ago and hence I thought that maybe I could post this as an issue for this project. Sorry if that was all wrong...
All in all...I am trying to create some kind of "manual pull-request" for this project. Please let me know if I can send this to anyone, or do this in a better way.
My cloned is repo here: https://github.com/GruffyPuffy/baseflight
The branch is called "xbus", there is also a pending PR for inside my repo here:
https://github.com/GruffyPuffy/baseflight/pull/1
Best regards
Stefan
There are many inconsistencies in the code which do not follow
https://github.com/multiwii/baseflight/wiki/CodingStyle
On Sun, Dec 21, 2014 at 9:47 PM, Stefan Grufman notifications@github.com
wrote:
Hi all!
Sorry if this is totally wrong place for this. Please remove it if so...
Well, I have a contribution for the baseflight project. It is an
implementation of JR Propo's XBus serial receivers. Originally I did
implement this by forking the "cleanflight" first and made a PR to that
project. Then I started to work on the same contribution, but now for
"baseflight" (as they differ a little). It was however not possible to
create a new "fork" within GitHub as I had already forked the "cleanflight"
(as this is a fork of "baseflight")... :(So, I created a "copy" manually here on GitHub and did a branch called
"xbus" and made a PR to my own repo.Is it possible to send this to anyone manually as it seems impossible to
have two different forks with the same base project as I tried? The private
message function has been removed from github a few years ago and hence I
thought that maybe I could post this as an issue for this project. Sorry if
that was all wrong...All in all...I am trying to create some kind of "manual pull-request" for
this project. Please let me know if I can send this to anyone, or do this
in a better way.My cloned is repo here: https://github.com/GruffyPuffy/baseflight
The branch is called "xbus", there is also a pending PR for inside my repo
here:
GruffyPuffy/baseflight#1
https://github.com/GruffyPuffy/baseflight/pull/1Best regards
Stefan—
Reply to this email directly or view it on GitHub
#229.
Ahh...sorry for that. I used the cleanflight model. Will look that over and come back with a better version.
Incidentally, the code also violates DCL and thus cannot be merged into
baseflight.
On Sun, Dec 21, 2014 at 9:51 PM, Stefan Grufman notifications@github.com
wrote:
Ahh...sorry for that. I used the cleanflight model. Will look that over
and come back with a better version.—
Reply to this email directly or view it on GitHub
#229 (comment).
DCL? Could you please help me here?
https://github.com/multiwii/baseflight/blob/master/README.md
The "license" section.
On Sun, Dec 21, 2014 at 9:55 PM, Stefan Grufman notifications@github.com
wrote:
DCL? Could you please help me here?
—
Reply to this email directly or view it on GitHub
#229 (comment).
How does the code violate that when I wrote it? Because I contributed it to cleanflight first?
Correct, and "Dominic Clifton" have seen it.
On Sun, Dec 21, 2014 at 10:01 PM, Stefan Grufman notifications@github.com
wrote:
How does the code violate that when I wrote it? Because I contributed it
to cleanflight first?—
Reply to this email directly or view it on GitHub
#229 (comment).
Sad, but ok. Then I guess you can delete this issue. Thanks for all answers to my questions.
Best regards
Stefan
Update:
I have read the license quite a few times now and I cannot see how my contribution violates that...could you please explain it for me? I wrote the code myself and I contributed (not the same version, but close) it to cleanflight. At that time I was not aware of the baseflight license. The baseflight license mentions that it is GPLv3 for all except "Dominic Clifton", hence that would be GPLv3 for me? Or, am I forever disqualified from baseflight as I contributed to cleanflight?
Is there something that can be done in order to resolve this? I am only interested in flying with the use of my JR Radio... ;)
Best regards
Stefan
trollcop is not in position to dual-license multiwii code, so this repository is GPLv3; DCL is in violation with GPL terms.
