Softserial
ledvinap opened this issue · comments
Hello,
there is error in softserial code, fixed here: ledvinap/cleanflight@3b20b74
I can't see that URL, but I have a pretty good idea where it links.
unless you're opening a PR on this project, you're just wasting time.
On Nov 11, 2014 8:49 PM, "Petr Ledvina" notifications@github.com wrote:
Hello,
there is error in softserial code, fixed here: ledvinap@3b20b74
ledvinap/cleanflight@3b20b74—
Reply to this email directly or view it on GitHub
#190.
From commit:
Bit end timer must by shifted by half-bit period to startbit edge, so that next edges are in middle of bit interval. This behavior was masked with old timer code, but noise immunity was probably very low.
- TIM_SetCounter(softSerial->rxTimerHardware->tim, 0);
+ TIM_SetCounter(softSerial->rxTimerHardware->tim, softSerial->rxTimerHardware->tim->ARR / 2);
Took some time to find, so I thought it is good idea to fix in baseflight.
I'm sure you're capable of using github properly.
On Nov 11, 2014 9:01 PM, "Petr Ledvina" notifications@github.com wrote:
From commit:
Bit end timer must by shifted by half-bit period to startbit edge, so that
next edges are in middle of bit interval. This behavior was masked with old
timer code, but noise immunity was probably very low.
TIM_SetCounter(softSerial->rxTimerHardware->tim, 0);TIM_SetCounter(softSerial->rxTimerHardware->tim, softSerial->rxTimerHardware->tim->ARR / 2);Took some time to find, so I thought it is good idea to fix in baseflight.
—
Reply to this email directly or view it on GitHub
#190 (comment).
@ledvinap: Just surf to https://github.com/multiwii/baseflight and there should be a button offering you to open a Pull Request with your changes.
Well, I don't want to waste my time ...
@fiendie: My changes are against cleanflight, so creating pull request is a bit more complicated ..
On Tue, Nov 11, 2014 at 9:52 PM, Petr Ledvina notifications@github.com
wrote:
Well, I don't want to waste my time ...
You pretty much nailed it, neither do I.