Giters

multiprocessio / dsq

Commandline tool for running SQL queries against JSON, CSV, Excel, Parquet, and more.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

suggestion to use v prefix for tags

kamilsk opened this issue · comments

commented

Hi! Based on this approach https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module to track tool dependencies for a module, as an example, I found a slight inconvenience when working with dsq, because dsq uses a different style to name tags. For go mod, it's recommended by this https://go.dev/ref/mod#versions

Each version starts with the letter v, followed by a semantic version

As a result, I have a pseudo-version like this instead of v0.21.0. It's challenging to understand which version is under the hood, actually. Is it possible to change the naming convention for tags?

commented

Interesting but why are you importing dsq at all? It isn't intended to be a library.

commented

I use it as a tool but use go mod to manage its version instead of https://github.com/multiprocessio/dsq#build-and-install-from-source.

commented

I have been wondering why the versions in go.mod are so ugly. I think I will adopt this v prefix.

However, embedded like this really isn't supported. I will probably remove the README note about go install. The problem is that go install ignores build tags and it is likely there will be build tags in the future.

You should only be using the binary installs or a dsq install script we eventually provide.

commented

I think I will adopt this v prefix.

great, thanks!

The problem is that go install ignores build tags and it is likely there will be build tags in the future.

I'm not sure. As I see

The build flags are shared by the build, clean, get, install, list, run, and test commands:

You could use something like this: go install -tags your-tag github.com/multiprocessio/dsq@latest. But I didn't test it.

You should only be using the binary installs or a dsq install script we eventually provide.

Not all binaries are presented here https://github.com/multiprocessio/dsq/releases/tag/0.21.0, for example, there is no amd64 (or am I wrong?)
UPD: sorry, I tested it on Intel and Arm, works well.

And as I see, brew uses go build https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/dsq.rb, it's the same as go install without some extra work

I have been wondering why the versions in go.mod are so ugly.

Me too, and now I know that go mod is sensitive to tag name :)