Typescript support

Question

Typescript support

itpropro opened this issue 3 years ago · comments

Jan-Henrik Damaschke commented 3 years ago

Hi,
Any plans to provide types and to rewrite the library in typescript?

Gie Katon · Answer 1 · Mon Sep 27 2021 20:03:13 GMT+0800 (China Standard Time)

Hi, no plans yet, but if this becomes a common request, then maybe I or someone else will do a rewrite in the future.

Ben Grynhaus · Answer 2 · Fri Oct 01 2021 21:21:58 GMT+0800 (China Standard Time)

Added types via DefinitelyTyped/DefinitelyTyped#56106.
@giekaton If you prefer, I can close that PR and instead create one for this repo, so it wouldn't require users to install two packages (@multiavatar/multiavatar + @types/multiavatar__multiavatar (as a dev dependency)).

Gie Katon · Answer 3 · Thu Oct 07 2021 10:52:12 GMT+0800 (China Standard Time)

Hi @bengry. Thank you for the contribution!

As I see, your code doesn't install any packages, which is good, as the philosophy of Multiavatar design is to keep everything as simple as possible and dependency-free.

Please create a PR for this repo. It would be great to have it very minimalistic. Don't close the one on DefinitelyTyped yet.