mubaris / yes

yes - Implementation of simple and dangerous yes command in various languages. :+1:

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

BUILD_LASTEXIT is not cleared

mewa opened this issue · comments

commented

When calling BUILD-FAIL, the BUILD_LASTEXIT variable is being set. However it is only cleared in BUILT and changed in BUILD-RUN.

This leads to a scenario where if after calling BUILD-FAIL the next language is missing a compiler this will not be indicated. It also messes the layout of the messages printed.

Example:

  1. Erlang fails with BUILD-FAIL "TODO BUILD SCRIPT".
  2. I don't have fish so case is not matched - it skips to BUILD-END
  3. Because BUILD-LASTEXIT is still set to "FAIL" it exits without printing anything.
BUILD-END() {
	# Fail command.
	if [ "${BUILD_LASTEXIT}" = "FAIL" ]; then
		return 0;
	fi
...

Was this fixed? Should it be closed?

Sorry, It's closed.