StereoAudioRecorder gobbles memory; how to release?

Question

StereoAudioRecorder gobbles memory; how to release?

darrellsilver opened this issue 5 months ago · comments

Long recordings eat up a lot of memory, how to release it? Just using Chrome / Mac the below simple code, and have tried several methods implied by their names to clear any stored data.

Shutting off the recording stops the accumulation but that won't work in my application. Any ideas?

<html>
    <head>
        <script src="https://www.WebRTC-Experiment.com/RecordRTC.js"></script>
        <script>
        let mediaRecorder;
        function startRecording() {
            navigator.mediaDevices.getUserMedia({audio: true}).then((stream) => {
                // audioStream = stream
                mediaRecorder = new RecordRTC(stream, {
                    type: "audio",
                    mimeType: "audio/wav;codecs=pcm", // endpoint requires 16bit PCM audio
                    recorderType: StereoAudioRecorder,
                    timeSlice: 250, // set 250 ms intervals of data that sends to AAI
                });
                mediaRecorder.startRecording();
            });
        }
        </script>
    </head>
    <body onload="startRecording()">
        <h1>leaky memories</h1>
    </body>
</html>

Trying these either break the recording or have no apaprent effect:

clearRecordedData()
clearRecordedDataCB()
resetVariables() <-- doesn't work
reset() <-- stops recording

Darrell Silver · Answer 1 · Thu Feb 01 2024 06:32:43 GMT+0800 (China Standard Time)

Got it working by manually freeing the data stored by StereoAudioRecorder. Seems like a hack so going to leave this issue open w/ my code.

Add a freeMemory func to RecordRTC.js:

    function resetVariables(stopRecording) {
        leftchannel = [];
        rightchannel = [];
        recordingLength = 0;
        if (stopRecording === undefined) {
            console.log('stopRecording all');
            isAudioProcessStarted = false;
            recording = false;
            isPaused = false;
            context = null;
        }

        self.leftchannel = leftchannel;
        self.rightchannel = rightchannel;
        self.numberOfAudioChannels = numberOfAudioChannels;
        self.desiredSampRate = desiredSampRate;
        self.sampleRate = sampleRate;
        self.recordingLength = recordingLength;

        intervalsBasedBuffers = {
            left: [],
            right: [],
            recordingLength: 0
        };
    }

    this.freeMemory = function() {
        resetVariables(false);
    }

Then in my code, as part of ondataavailable I call
mediaRecorder.getInternalRecorder().freeMemory()

According to Chrome Memory tool it works & in Safari too (Silicon Mac 13.4.1).

Augusto Maillo · Answer 2 · Fri Apr 05 2024 07:05:56 GMT+0800 (China Standard Time)

I was struggling to deal with this memory consumption. I ended up removing RecordRTC.js lines 3136, 3141 and 3144. This class absolutely save me, but this "memory leak" almost ruins everything.

Maybe some config in constructor do control wheter to keep this buffer or not, or the maximum number of bytes to save, can be very helpful.

gabrielcardetti · Answer 3 · Thu Jun 13 2024 18:29:19 GMT+0800 (China Standard Time)

Got it working by manually freeing the data stored by StereoAudioRecorder. Seems like a hack so going to leave this issue open w/ my code.

Add a freeMemory func to RecordRTC.js:

    function resetVariables(stopRecording) {
        leftchannel = [];
        rightchannel = [];
        recordingLength = 0;
        if (stopRecording === undefined) {
            console.log('stopRecording all');
            isAudioProcessStarted = false;
            recording = false;
            isPaused = false;
            context = null;
        }

        self.leftchannel = leftchannel;
        self.rightchannel = rightchannel;
        self.numberOfAudioChannels = numberOfAudioChannels;
        self.desiredSampRate = desiredSampRate;
        self.sampleRate = sampleRate;
        self.recordingLength = recordingLength;

        intervalsBasedBuffers = {
            left: [],
            right: [],
            recordingLength: 0
        };
    }

    this.freeMemory = function() {
        resetVariables(false);
    }

Then in my code, as part of ondataavailable I call mediaRecorder.getInternalRecorder().freeMemory()

According to Chrome Memory tool it works & in Safari too (Silicon Mac 13.4.1).

Today I was dealing with the same problem, I could see in the chrome memory how RecordRTC was allocating memory non-stop, for now adding this function solved the problem.