mtgjson / mtgjson3

MTGJSON repository for Magic Cards

Home Page:http://mtgjson.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

C18 is missing from AllCards, AllSets-x, and AllSets

ancestral opened this issue · comments

Cards (or at least new cards) from C18 are missing from three of four compiled JSON files.

If you do a search for Yuriko (one of the new commanders from the set) you should see it at least once, but it’s only in one of the four files. The same goes for other new Commander 2018 cards.

I'm honestly not sure why this is going haywire like this...

Realized that yesterday already after the update, thought it's some caching issue or that the allsets files needs to get internally created/deployed first after a change.

It's possible the files didn't get cached yet as cloudflare is being annoying

How are the allsets, allsets-x, allcards etc. files created btw?
As we don't keep them in the repo and don't update them as we do with the others.

Maybe we should start doing so if that solves the issues with big delays?

commented

Hmm. In version 4 we won't have build artifacts in the repo at all. Since that's not an option for v3 though, I think it would make sense to be consistent and have all of the build artifacts in the repo.

FYI: The first attempt on v4 by @lsmoura (https://github.com/mtgjson/mtgjson4_temporary) used a separate repo for storing (https://github.com/mtgjson/db) as described here.

This is fixed now, right?

Should be