sets_config of many many sets are incomplete
tooomm opened this issue · comments
-
Files like https://github.com/mtgjson/mtgjson/blob/master/shared/set_configs/AKH.json or https://github.com/mtgjson/mtgjson/blob/master/shared/set_configs/HOU.json
are missing translated names, mkm info etc. completely! -
Files like https://github.com/mtgjson/mtgjson/blob/master/shared/set_configs/RIX.json (and actually all others too) miss translated names for chinese (simplified+traditional, see: mtgjson/mtgjson#527), korean and japanese!
One with all translations available is: https://github.com/mtgjson/mtgjson/blob/master/shared/set_configs/OGW.json
If you'd like to make changes to them and open a PR that would be awesome!
What are the information needed for, or how do we further process them?
And where could we get them from? (e.g. mkm_name, mkm_id?)
Which are crucial, which do we want for sure?
It would require a lot of manual work and time to fix all set files...
Regarding language names we use different patterns in different set configs, too!
tw and cn for both versions of chinese in https://github.com/mtgjson/mtgjson/blob/master/shared/set_configs/M15.json#L19-L21
vs zh-hans and zh-hant in https://github.com/mtgjson/mtgjson/blob/master/shared/set_configs/OGW.json#L22-L23
While the first are stay two digits only, they are not as correct.
Scryfall uses this language codes: https://scryfall.com/docs/api/languages
We now use SF's set configs. Moot ticket