mt-mods / pipeworks

Pipeworks is a mod for Minetest allowing the crafting and usage of pipes and tubes

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Change 'mesecons' from optional dependencies to dependencies

GrimPixel opened this issue · comments

If I don't enable mesecons, it will say

ModError: Failed to load and run script from /home/user/.minetest/mods/pipeworks/init.lua:
/home/user/.minetest/mods/pipeworks/lua_tube.lua:302: attempt to index global 'mesecon' (a nil value)
stack traceback:
/home/user/.minetest/mods/pipeworks/lua_tube.lua:302: in main chunk
[C]: in function 'dofile'
/home/user/.minetest/mods/pipeworks/init.lua:147: in main chunk
Check debug.txt for details.

Can you check your setup: this should not happen unless you have the digilines mod enabled (which should not work without mesecons iirc)

pipeworks/init.lua

Lines 181 to 184 in e45eca7

if pipeworks.enable_lua_tube and
(minetest.get_modpath("mesecons") or minetest.get_modpath("digilines")) then
dofile(pipeworks.modpath.."/lua_tube.lua")
end

Your mod(s) might be out of date

commented

I think lua tube requires both so we could make it explicit to not depend on external dependency

- 		(minetest.get_modpath("mesecons") or minetest.get_modpath("digilines")) then
+ 		minetest.get_modpath("mesecons") and minetest.get_modpath("digilines") then

or if digilines is actually optional for lua tube (mesecons isn't, probably same with digilines but not 100% sure):

- if pipeworks.enable_lua_tube and 
- 		(minetest.get_modpath("mesecons") or minetest.get_modpath("digilines")) then 
+ if pipeworks.enable_lua_tube and minetest.get_modpath("mesecons") then

Can you check your setup: this should not happen unless you have the digilines mod enabled (which should not work without mesecons iirc)

pipeworks/init.lua

Lines 181 to 184 in e45eca7

if pipeworks.enable_lua_tube and
(minetest.get_modpath("mesecons") or minetest.get_modpath("digilines")) then
dofile(pipeworks.modpath.."/lua_tube.lua")
end

Your mod(s) might be out of date

it does "work" without mesecons or at least it boots without crashing https://github.com/minetest-mods/digilines/blob/master/mod.conf#L2

it does "work" without mesecons

Sooo, this is still an issue then? see first post

EDIT: nevermind, didn't see the commit 🤦