mt-mods / mt-mods

mt-mods meta repository for management and issues

Home Page:https://discord.gg/8k3K5nyj7x

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Use `actions/checkout@main` for all GitHub workflows

Panquesito7 opened this issue · comments

Description

Most of the GitHub workflows use actions/checkout@v1 for LuaCheck mostly.
It is recommended to use the latest, stable version, which is v3.

This is not something critical, but it'd be great if we could update those.
What do you think about this? We can create PRs/commit for that. 🙂

this issue seems like a waste(unless your going to track specific repos statuses here), just make the prs to the relevant repos

edit: or tbh, trivial enough so just commit directly to them

just commit directly to them

yeah, this is trivial enough 👍

Would there be any reason not to use actions/checkout@main? Then we wouldn't need to update it again.

commented

Would there be any reason not to use actions/checkout@main? Then we wouldn't need to update it again.

Been broken before so there's that. Also as far as I know there's no really need to update from 2.x at all with current mt-mods use, new features are not used here at all.

To keep using somewhat tested release it is probably better to use v3 instead of following development.
If tested stability is concern then v2 would be best as it seems to be still getting bug fix releases, just no new features (or new bugs).

I've got nothing against update to v3 but I think it would still be good to use releases, we are not checkout action developers after all and therefore want somewhat stable platform instead of bleeding edge.

If this sounds good, I'll commit directly to the repositories and update them.