Consider renaming `which` to `where`
kimroen opened this issue · comments
The property used to filter in mswjs/data is named which
, citing being heavily inspired by Prisma. However, Prisma does not use which
, it uses where
:
https://www.prisma.io/docs/concepts/components/prisma-client/filtering-and-sorting
Is it possible that this is a mistake?
where
is also the preferred word for other ORMs (presumably because the keyword is WHERE
in SQL), such as:
Non-js:
Thank you for reporting this, @kimroen. You're absolutely right, and the which
choice is an oversight on my part (@msutkowski has also pointed this out). I think we should adopt where
instead.
Please, would you be interested in shipping this change?
Wonderful 👍 🎉