mstorsjo / fdk-aac

A standalone library of the Fraunhofer FDK AAC code from Android.

Home Page:https://sourceforge.net/projects/opencore-amr/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

bad result for he-aac v2

myfreeer opened this issue · comments

Version: e7f36eed224b9530cf0eb7e56d6c43d3de14429e\
Platform: win64
Compiler: msvc
Frontend: nu774/fdkaac@4571d9d
Audio Src: https://archive.org/download/Pnuma2005-09-01/pnuma2005-09-01d1t07.flac
Cmd Line: flac -d pnuma2005-09-01d1t07.flac -o - | fdkaac - -m3 -p29 -o m3.aac
Result: m3.zip

Edit: Probably caused by commit 39e13c1 , I reverted this commit manually and he-aac v2 goes fine.

I tested the same setup more or less, on linux, and it seems to work fine.

A suspicion is that the binary data might be corrupted when piping, when on windows. Can you try by decoding into a wav file with flac separately (and please verify that it is ok), and then naming that input wav file to fdkaac, instead of using a pipe?

Cmd Line:

flac -d pnuma2005-09-01d1t07.flac
./fdkaac pnuma2005-09-01d1t07.wav -m3 -p29 -o m3.aac

Result: m3.zip

Edit: And the wav went just fine

Oh, indeed - I didn't test using the latest master version when I built the third party fdkaac frontend, but now I can reproduce the issue, and as you say, this commit seems to be the culprit. I'll revert that and look for a better fix for the fuzz crash.

Thanks for reporting and thanks for identifying the offending commit!