Assertions should not abort/crash the encoding process

[raresp]

I am transcoding something with ffmpeg and fdk-aac. Seems like there is a data error in the audio stream.
fdk-aac causes ffmpeg to exit with error.
The encoder should not abort, it should be able to go on with the encoding and deal with this invalid data.
Same data works with vo-aacenc

Here is a the error message.

[mp2 @ 0x1673f60] Header missing
Error while decoding stream #0:1: Invalid data found when processing input
ffmpeg: ./libFDK/src/fixpoint_math.cpp:397: FIXP_DBL invSqrtNorm2(FIXP_DBL, INT*): Assertion `val > (FIXP_DBL)( ( (0.0) >= 0) ? ((( (double)(0.0) * (((INT64(1)<<(32-1)))) + 0.5 ) >= (double)(((signed)0x7FFFFFFF)) ) ? (INT)(((signed)0x7FFFFFFF)) : (INT)( (double)(0.0) * (double)(((INT64(1)<<(32-1)))) + 0.5)) : ((( (double)(0.0) * (((INT64(1)<<(32-1)))) - 0.5) <= (double)(((signed)0x80000000)) ) ? (INT)(((signed)0x80000000)) : (INT)( (double)(0.0) * (double)(((INT64(1)<<(32-1)))) - 0.5)) )' failed.
Aborted

[Martin Storsjö]

Can you share the file (and parameters used) that cause this crash? That'd be very helpful for tracking it down. And did you try the latest version from git? I fixed a bunch issues like this one a while back.

[raresp]

thanks for the quick reply. the tar with files is about 157M. Where can I drop it?

[Martin Storsjö]

Anywhere I can fetch it, dropbox perhaps?

[raresp]

http://dl.dropbox.com/u/12255037/test.tar

the command is inside
using a lib compiled two days ago for git

[Martin Storsjö]

Thanks! I can reproduce the crash now, I'll look into how to fix it.

[Martin Storsjö]

This particular crash should be fixed now, although I'm pretty sure there might still be more various crashes there with different uncommon inputs...