Package name should be useragent, not user_agent
peterbourgon opened this issue · comments
By convention, packages are given lower case, single-word names; there should be no need for underscores . . .
https://golang.org/doc/effective_go.html#package-names
Good package names . . . are lower case, with no under_scores or mixedCaps.
Thanks for reaching out. Yes, I know, that's something I realized some time after creating the package. However I don't want to break code from people by changing the name of the package...
You're still on major version 0, it shouldn't be a problem.
@mssola I'm considering using your library in one of my projects, but I'd really like you to rename the package please if you're okay with this. Breaking the ~200 something imports 😳 won't be a big deal if you fork the codebase into a v2 package or something similar which I've seen other projects do.
Can we do that? 🤔
Done. See: https://github.com/mssola/useragent