GitHub Actions questions
mroswell opened this issue · comments
Marjorie Roswell commented
- Does the db backup work?
- If three errors, will I lose the db?
- Is it pushing to Vercel, even if there were no changes?
Readul Hasan Chayan commented
- Yes.
- No. Any error (exit status != 0) in any step would prevent the next step from being run so if the fetched JSON data from EPA is not in the right format (e.g.), we would get something like
parse error: Invalid ...
fromjq
and the next steps won't run so no DB is created/rotated. For example: https://github.com/mroswell/list-N/runs/2519369155?check_suite_focus=true - Yes. We can probably use
diff
to make sure the pushing only happens when there's difference(s) between the new and old JSON data.
Marjorie Roswell commented
Old: epa_json_data=$(curl "https://cfpub.epa.gov/giwiz/disinfectants/includes/queries.cfc?method=getDisData&Keyword=&RegNum=&ActiveIng=All&ContactTime=&UseSite=&SurfType=" 2>/dev/null)
New: epa_json_data=$(curl "https://cfpub.epa.gov/wizards/disinfectants/includes/queries.cfc?method=getDisData&Keyword=&RegNum=&ActiveIng=All&ContactTime=&UseSite=&SurfType=" 2>/dev/null)
just giwiz
changed to wizards