Giters

mrhooray / crc-rs

Rust implementation of CRC(16, 32, 64) with support of various standards

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Bench testing no longer working in Rust 1.26 stable

CLomanno opened this issue · comments

commented

Code throws an error at benches\bench.rs at line 1:

crc-rs/benches/bench.rs

Line 1 in 322576d

#![feature(test)]

Rust error:
error[E0554]: #![feature] may not be used on the stable release channel

commented

@CLomanno if i'm not mistaken, bencher was never in stable.
see https://doc.rust-lang.org/1.26.0/test/struct.Bencher.html

did it ever work for you on stable?
also looks like you've started using criterion for benchmark in #32 so i'd suppose this isn't a blocker

commented

Are you planning on keeping the code in benches/bench.rs or removing it going forward? In its current state, it throws an error in my IDE with stable.