replace `Digest::new` with table specific digests
vitiral opened this issue · comments
Rett Berg commented
Is there a reason there isDigest::new
instead of just:
Digest::new_ieee()
Digest::new_castagnoli()
where those methods just copy the already computed tables.
With #13 this could remove make_table
from the library. If the user wants to use their own table, couldn't they compute it (using a new crate crc-table
) and pass it in?
I'm willing to work on this.
Rett Berg commented
I take back removing make_table
from the library -- keep it in. But we should have table-specific digests that don't require using it (since they are precomputed)
Rui Hu commented
Rett Berg commented
I think this isn't really that importnat anymore.
Thanks