mpvnet-player / mpv.net

🎞 mpv.net is a media player for Windows with a modern GUI.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Context menu no longer opens in certain `settings.xml` conditions.

Sneakpeakcss opened this issue · comments

Describe the bug

Since changes in edcd8be, the context menu no longer opens when a - path is added to <RecentFiles>. This kind of path is added when opening livestreams through streamlink.

To Reproduce

<?xml version="1.0" encoding="utf-8"?>
<AppSettings xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
    <InputDefaultBindingsFixApplied>true</InputDefaultBindingsFixApplied>
    <ShowMenuFixApplied>true</ShowMenuFixApplied>
    <MenuUpdateVersion>1</MenuUpdateVersion>
    <Volume>70</Volume>
    <RecentFiles>
        <string>-</string>
    </RecentFiles>
    <WindowLocation>
        <X>0</X>
        <Y>0</Y>
    </WindowLocation>
    <WindowPosition>
        <X>0</X>
        <Y>0</Y>
    </WindowPosition>
    <WindowSize>
        <Width>0</Width>
        <Height>0</Height>
    </WindowSize>
    <AudioDevice />
    <ConfigEditorSearch>Video:</ConfigEditorSearch>
    <Mute>no</Mute>
    <StartupFolder />
</AppSettings>

Steps to reproduce the behavior:

  1. Add the above to settings.xml

Expected behavior

Well… Context menu should open lol.

Additional context

This technically happens even before the write to settings.xml (at least for that single instance of mpv.net), at the point when a 'video' with this path is loaded.

 

  1. mpv.net version: every build since edcd8be
  2. Windows version: WIN10 22H2

Good it was found before the release.