[Feature request] Automatically stringify JSON

[KaKi87]

Thanks

[Robin Millette]

@mpetrunic If there's interest, I can make a PR for this.

[Marin Petrunić]

Maybe you can first propose approach here (without breaking changes)? :)

[KaKi87]

Simple : reply.sse({ data: JSON.stringify({ 'foo': 'bar' }) }) keeps working but can be simplified with reply.sse({ data: { 'foo': 'bar' } }), which currently has no use case since it sends [Object object].

Thanks

[Marin Petrunić]

Ah I see, stringify data if it's an object. Yeah, I'm happy to accept PR with the changes.

[Robin Millette]

Oh wow, I completely missed this issue. I'll have a look around tomorrow and get to it if nobody else started the PR.

[Dama Lo]

In some cases, JSON.stringify is not very good, and we need other libraries to improve stringify performance.

[Dama Lo]

SSE common scenarios involve high-frequency requests. We need to reduce consumption.

[KaKi87]

Yeah, I was just making an example, in practice I guess the library that Fastify currently uses for serializing JSON should be used here.

[Robin Millette]

@KaKi87 https://www.npmjs.com/package/fast-json-stringify

See also:

• https://www.npmjs.com/package/JSONStream#jsonstreamstringifyobjectopen-sep-close
• https://www.npmjs.com/package/bfj#how-do-i-create-a-json-string looks promising.

[Dama Lo]

just use JSON.stringify, we can edit this file.

https://github.com/mpetrunic/fastify-sse-v2/blob/master/src/sse.ts

export function isObject(value: any) {
  return typeof value === 'object' && value !== null;
}

...

  if (chunk.data) {
    if (isObject(chunk.data)) {
      payload += `data: ${JSON.stringify(chunk.data)}\n`;
    } else {
      payload += `data: ${chunk.data}\n`;
    }
  }