mpetroff / pannellum

Pannellum is a lightweight, free, and open source panorama viewer for the web.

Home Page:https://pannellum.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Black squares on multires panorama on low screen size

ArFnds opened this issue · comments

When displaying the multires example on mobile, or by adjusting the width, some tiles does not display :

image
image

Step to reproduce:

  • Load the sample on an standalone page
  • Lower the width of the screen using Developers Tools or load it on a mobile phone
  • Rotate until it happens

Looks like this one : #786

Which version of Pannellum and what browser and browser version are you using?

In #786, the issue was that there were missing tiles while the panorama was loading (which has since been resolved with the addition of spherical harmonics based previews). My interpretation of what you're reporting is that the tiles never load, which would be a different issue.

I have build the project from the master branch.

Mobile:

  • Safari on iOs
  • Chrome 121 on Android
  • Yandex 24 on windows (Chromium based)

On mobile, the black squares disappear after a few moment, it seems to load little tiles. But I am on the same Wifi as my computer (which has no problem on full size), and my phone is not old (Samsumg S21).

Maybe le tiles are loaded again and again from internet, which can cause this "always loading tiles issue" on mobile.

I may not be pointing the right problem. Here is a gif of the issue when resizing on computer :
https://freeimage.host/i/J0Dj0vI

This was a regression due to a bug in an optimization introduced in 05dae19. I fixed the bug in 8f7a888 and further improved the optimization in 021b512, which reduces the unnecessary drawing of tiles that have their children drawn on top of them, reducing the total number of draw calls per frame.