`thunk` type annotations are incorrect

Question

`thunk` type annotations are incorrect

Gozala opened this issue 8 years ago · comments

Irakli Gozalishvili commented 8 years ago

We assumed that thunk could take functions that return any kind of Virtual Element. Turns out it needs to be a Node as neither ThunkNode nor TextNode are supported.

Type annotations should reflect that so type checker could catch those errors.

Irakli Gozalishvili · Answer 1 · Tue Jun 28 2016 03:15:06 GMT+0800 (China Standard Time)

For details see browserhtml/browserhtml#1102

Irakli Gozalishvili · Answer 2 · Tue Jul 04 2017 06:51:04 GMT+0800 (China Standard Time)

Closing in favor of mozilla/reflex-virtual-dom-driver#10