mozilla / node-firefox

node.js modules for interacting with Firefox via the DevTools remote protocol

Home Page:https://www.npmjs.org/package/firefox

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

es6-Promise should be es6-promise

aduros opened this issue · comments

commented

Almost all of the node-firefox modules have lines like this:

var Promise = require('es6-Promise').Promise;

This fails on case-sensitive filesystems (Linux). The correct case is es6-promise.

After I made all the replacements, things seem to work surprisingly well on Linux! You might be able to update your support matrix after this change. ;)

(Example: https://github.com/mozilla/node-firefox-find-app/blob/master/index.js#L5)

Ah, thanks you! I recall this was caught someplace else but I guess not in
every module. Thanks!

-tofumatt
On 3 Mar 2015 22:45, "Bruno Garcia" notifications@github.com wrote:

Almost all of the node-firefox modules have lines like this:

var Promise = require('es6-Promise').Promise;

This fails on case-sensitive filesystems (Linux). The correct case is
es6-promise.

After I made all the replacements, things seem to work surprisingly well
on Linux! You might be able to update your support matrix after this
change. ;)

(Example:
https://github.com/mozilla/node-firefox-find-app/blob/master/index.js#L5)


Reply to this email directly or view it on GitHub
#28.

This should be fixed. I'm going to try doing some full runs of the module stack on Linux later today / tomorrow, so that will expose any more we've missed.

commented

Thanks for the quick fixes!

It looks like launch-app and uninstall-app still need updating.

Doh, premature close then :) Threw in a couple of PRs for those two...

mozilla/node-firefox-launch-app#4
mozilla/node-firefox-uninstall-app#2

Merged, so once these are released on npm we should close

Just pushed updates to git and npm for all the modules!