Giters

mozilla / mozjpeg

Improved JPEG encoder.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Multiple failures when running make test on v4.0.0

graysky2 opened this issue · comments

commented

After building tag v4.0.0, I ran make test and found that 31 of the 151 failed. Is this expected? Perhaps I am missing a dependency?

Build system is Arch Linux building in a clean buildroot.

cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_INSTALL_LIBDIR=/usr/lib \
-DENABLE_STATIC=FALSE -DPNG_SUPPORTED=TRUE -DWITH_JPEG8=TRUE
make
  • Log of cmake and make output.
  • Log of make test output.
commented

I'm seeing the same failures. These failures are sort-of expected, because the tests come from libjpeg-turbo. They are just md5 hashes of output files, so they are very sensitive to the smallest changes of the implementation.

I've checked the results manually, and all the differences that are reported are so tiny they're imperceptible. Probably just rounding errors or some float shenanigans.

I'll just update expected hashes to match the files that are being generated.