Move GPG tests out of client.NewClient

Question

Move GPG tests out of client.NewClient

ameihm0912 opened this issue 7 years ago · comments

NewClient currently runs a test to see if it can obtain a signed token to validate the key ring is accessible.

There are some cases where client functions are used where the PGP signature is not actually required. An example is a scenario where you want to generate and display a JSON action (mig-cmd's -p option).

A separate function to test the GPG integration would be useful as it could be called explicitly prior to entering any code where signing will be occurring, and we just wouldn't test the integration when signing is not required.

Aravind K P · Answer 1 · Sun Aug 20 2017 10:57:31 GMT+0800 (China Standard Time)

Hi. I would love to take this issue. I'm a beginner and pretty new to the mig project.

Cheryl Fong · Answer 2 · Tue Oct 24 2017 02:39:35 GMT+0800 (China Standard Time)

Hello @scriptonist, did you get to resolve this issue?

Aravind K P · Answer 3 · Wed Jan 10 2018 23:37:33 GMT+0800 (China Standard Time)

I'm very sorry. I totally forgot about this since I was not assigned.

Malhar Vora · Answer 4 · Sat Jan 27 2018 02:11:14 GMT+0800 (China Standard Time)

@ameihm0912 I think this issue can be closed.