Giters

mozilla / fxa-content-server-l10n

translated strings for Firefox accounts website

Repository from Github https://github.commozilla/fxa-content-server-l10nRepository from Github https://github.commozilla/fxa-content-server-l10n

Was change from 'Language: pt_BR' to 'Language: pt-BR' correct?

jrgm opened this issue · comments

commented

See this comment in mozilla/fxa-auth-mailer#46 (comment)

In c26368b, the Language: header was changed from pt_BR to pt-BR, which is unlike all the other country-specific locales in this repository. Was that a correct change? Can they be used interchangeably?

(Of course, crashing on this change is a bug in the fxa-auth-mailer, for any inputs).

commented

So I fixed the code in mozilla/fxa-auth-mailer so it handles either form. And perhaps the answer on this issue is that either form is valid (but it does feel random).

commented

This is another locale switching to Pontoon.

However, looks like Pontoon is wrong on this one, should use underscore instead of dash:
https://www.gnu.org/software/gettext/manual/html_node/Header-Entry.html

commented

Hotfix landed in Pontoon:
ee79552

commented

Should be fixed when this is getting deployed.