cargo install fails on current main due to goblin version inconsistencies
jangmarker opened this issue · comments
symbolic-debuginfo has bumped goblin to 0.7 [0] and it appears that leads to:
Installing dump_syms v2.2.1 (/Users/build/source/dump_syms)
Updating crates.io index
Compiling dump_syms v2.2.1 (/Users/build/source/dump_syms)
error[E0308]: mismatched types
--> src/object_info.rs:139:21
|
138 | collector.collect_placeholder_functions(
| ----------------------------- arguments to this method are incorrect
139 | exception_data,
| ^^^^^^^^^^^^^^ expected `ExceptionData<'_>`, found a different `ExceptionData<'_>`
|
= note: `ExceptionData<'_>` and `ExceptionData<'_>` have similar names, but are actually distinct types
note: `ExceptionData<'_>` is defined in crate `goblin`
--> /Users/build/.cargo/registry/src/index.crates.io-6f17d22bba15001f/goblin-0.7.1/src/pe/exception.rs:656:1
|
656 | pub struct ExceptionData<'a> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: `ExceptionData<'_>` is defined in crate `goblin`
--> /Users/build/.cargo/registry/src/index.crates.io-6f17d22bba15001f/goblin-0.6.1/src/pe/exception.rs:656:1
|
656 | pub struct ExceptionData<'a> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: perhaps two different versions of crate `goblin` are being used?
note: method defined here
--> src/collector.rs:426:12
|
426 | pub fn collect_placeholder_functions(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
427 | &mut self,
428 | exception_data: &ExceptionData,
| ------------------------------
dump_syms still depends on goblin 0.6. There's #604 which asks to bump goblin for this project.
Right, I'm bumping the goblin version and cutting a new release
Version 2.2.2 is out fixing this issue