Don't nag to set severity when severity is explicitly set to `N/A`
dholbert opened this issue · comments
In https://bugzilla.mozilla.org/show_bug.cgi?id=1866692#c1 , the severity had been previously set to N/A but BugBot still nagged and said "The severity field is not set for this bug."
Probably we should have BugBot consider Severity:N/A bugs as "triaged" & not needing further severity modifications. (Or if we want to explicitly prohibit N/A severity, we should perhaps encode that in bugzilla somehow.)
N/A is actually prohibited according to the triage rules: https://firefox-source-docs.mozilla.org/bug-mgmt/policies/triage-bugzilla.html#multiple-times-weekly.
I agree encoding in Bugzilla might be nicer.
Aha, thanks.
In the meantime (if it's complex to rip out N/A from bugzilla), it might be better to have BugBot swap to a custom message for this case. So no change in what-bugs-to-nag-about, but instead: when we're about to report a "The severity field is not set" nag, check whether we actually have Severity:N/A and if so, swap to a different message that points out that this value is prohibited for Type:Defect bugs.
(The bot could maybe even suggest that such bugs are often best reclassified as either Severity:S4 or Type:Task.)
@dklawren wdyt?
@dklawren wdyt?
We have ~1640 bugs current marked with that severity so I cannot just delete without moving to something else. I can disable the value so that it cannot be used for new bugs or for bugs that are not currently set to it. Should I do that for now?
In this context, the goal is to prevent setting the Severity to N/A when the bug type is defect. We currently have 73 open defect bugs with their Severity set to N/A: https://bugzilla.mozilla.org/buglist.cgi?bug_severity=N%252FA&bug_type=defect&resolution=---. I do not think there is a need to change these ones for now.
It would be useful to prevent having new ones. We could achieve that by disabling it from the UI for defect bugs only. Also, it would be great if we could add a post hook to the MozChangeField extension that automatically changes the Severity to -- if the bug's type is changed to defect while the Severity is still set to N/A.
In this context, the goal is to prevent setting the Severity to
N/Awhen the bug type isdefect. We currently have 73 open defect bugs with their Severity set toN/A: bugzilla.mozilla.org/buglist.cgi?bug_severity=N%252FA&bug_type=defect&resolution=---. I do not think there is a need to change these ones for now.It would be useful to prevent having new ones. We could achieve that by disabling it from the UI for defect bugs only. Also, it would be great if we could add a post hook to the
MozChangeFieldextension that automatically changes the Severity to--if the bug's type is changed todefectwhile the Severity is still set toN/A.
Totally doable. Please file a bug report for tracking and I will take a look.