Giters

mozilla-mobile / fenix

⚠️ Fenix (Firefox for Android) moved to a new repository. It is now developed and maintained as part of: https://github.com/mozilla-mobile/firefox-android

Home Page:https://github.com/mozilla-mobile/firefox-android

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Implement extension runtime permissions

cognition9144 opened this issue · comments

commented

Steps to reproduce

  1. Go to Settings of an extension with runtime permission request (should be options.html on desktop)
  2. Let the extionsion request runtime permissions. Say, click Grant permission in the Settings page

Expected behavior

A popup is shown to grant/deny the runtime permission request

Actual behavior

Nothing happens.

Device information

  • Android device: Android 10
  • Fenix version: Nightly 201207 17:01 (Build #2015780043)

┆Issue is synchronized with this Jira Task

commented

Same on Android 11. Latest nightly. Tried to get one of my Add-ons to work on Nightly: https://addons.mozilla.org/firefox/addon/togglereferrer/

Code execution immediately ends at the line

  const success = await browser.permissions.request(permissions);

No error messages in Console.

commented

Is there any timeline, to get this solved?

commented

As the "good old" Android Firefox, which had this feature, is no more and I want to get a usable environment on Android again, I decided to go for a temporary workaround.

A new Makefile target patches in a new Add-on ID (to make an independent clone of my Add-on) and then merges "permissions" with "optional_permissions" in this clone. Silly hack but it allows to make the feature work that requires the optional permissions. It just makes it impossible to enable it on demand. As this is primarily for my own need, I've checked the "experimental" checkbox for this.

commented

Looks like this feature first requires change in GeckoView: https://bugzilla.mozilla.org/show_bug.cgi?id=1601420

commented

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

commented

As https://bugzilla.mozilla.org/show_bug.cgi?id=1601420 is still open I think this Issue also still is not resolved.

commented

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

commented

Just tested. Still not fixed!

commented

The geckoview work to implement permissions.request has been completed. Fenix can now implement the new delegate method onOptionalPrompt.
Related patch: https://phabricator.services.mozilla.com/D143925
Related geckoview bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1601420

commented

I will try to add this work in the next Fenix sprint.

The linked Jira issue: https://mozilla-hub.atlassian.net/browse/FNXV2-9012

commented

Will fixing this also fix this:
#24637

commented

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

commented

This issue should be neverstale.

commented

Any news?

commented

Please don't post comments asking about progress, as it sends everyone who's subscribed to this issue an email. If nothing was said here then there is no news.