WebNotifications do not invoke any event when clicked

Question

WebNotifications do not invoke any event when clicked

jonalmeida opened this issue 4 years ago · comments

Jonathan Almeida commented 4 years ago

From a discussion in Slack, it seems that we may not be handling WebNotifications correctly as expected when clicked.

We should investigate why this is caused and how to fix it.

Are we invoking the onClick?
What does the onClick trigger in GV and is it being triggered?

┆Issue is synchronized with this Jira Task

Kevin Brosnan · Answer 1 · Tue Oct 06 2020 03:43:14 GMT+0800 (China Standard Time)

Seeing a few comments about this being broken and https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerGlobalScope/notificationclick_event says we support this event. Can we get this in an upcoming sprint? Do we need GV work to pass the event back to Gecko?

Jonathan Almeida · Answer 2 · Tue Oct 06 2020 04:34:09 GMT+0800 (China Standard Time)

Yes, we have the GV support. I'll add this to the sprint (or the next one if there isn't space).

Offerel · Answer 3 · Mon Mar 01 2021 18:16:06 GMT+0800 (China Standard Time)

The last response on this bug is from late last year, a long time ago now. The bug is currently open in Firefox Nightly. Any idea, when we can expect a fix for this?

Pato · Answer 4 · Mon Mar 29 2021 02:30:05 GMT+0800 (China Standard Time)

Hi I'm experiencing this issue as well. Hope this helps:

Steps to reproduce

Go to this demo website to send a push notifications: https://onesignal-fcm-e72c4.web.app/ on your mobile Android phone
Click on prompt
Go to this website on your computer https://onesignal-fcm-e72c4.web.app/
On the website listed above from your computer, click on SEND PUSH.
You should receive notification on your phone
If you click on the notification, Firefox opens but it doesn't open the URL that the push notification contains.

Expected behavior

On push notification clicked, Firefox will open the URL that the push notification contains

Actual behavior

On push notification clicked, Firefox will doesn't open the URL that the push notification contains. It works on Firefox for computer but not on mobile. Also, other browsers like Chrome and Brave do have the expected behavior. We have tried with OneSignal and Firebase Cloud Messaging and the bug happens in both Push notifications providers. Based on my research I think it's a bug on Firefox.

Device information

Device vendor / model and Android version: Google Pixel 5
Firefox for Android version: ? 87.0.0-rc-1

chrisausat · Answer 5 · Wed Sep 29 2021 23:36:54 GMT+0800 (China Standard Time)

I have the problem with ORF.at. When it sends a push message, Firefox Mobile opens. But the page to the push message does not open. On Firefox on Windows 10 it works.

Firefox Mobile 92.1.1 in Android 11

Bakso69 · Answer 6 · Tue Dec 28 2021 21:37:54 GMT+0800 (China Standard Time)

Firefox Mobile 95.2.0 same problem.

Josh Kasten · Answer 7 · Fri Feb 11 2022 09:51:25 GMT+0800 (China Standard Time)

Also able to reproduce the issue with the following steps on Firefox 97.1.0 on Android 12 on a Galaxy S21.

Open https://tests.peter.sh/push-message-generator/
Accept notification permissions
Go to https://tests.peter.sh/notification-generator/
Press "Display the notification"
Close the tab to the site.
Tap on the notification
Observer nothing happens
- If the FireFox app is closed or in the background it will resume, however it doesn't open the peter.sh site

On the same device with Chrome the above does correctly open the site again as expected.

Jonathan Almeida · Answer 8 · Wed Feb 23 2022 01:37:27 GMT+0800 (China Standard Time)

Agi also mentioned we need #10723 to land to properly fix this feature.

Chris Peterson · Answer 9 · Wed Feb 23 2022 03:29:10 GMT+0800 (China Standard Time)

The corresponding Jira issue: https://mozilla-hub.atlassian.net/browse/FNXV2-6474

Jonathan Almeida · Answer 10 · Thu Mar 03 2022 12:12:38 GMT+0800 (China Standard Time)

Cathy and I investigated into this issue and we had some findings that we can share here:

WebNotifications live on the GeckoRuntime.

In a GeckoView WebNotification, we need to trigger the dismiss method. Which we can probably do if we call it inside the AC WebNotification class:

fun GeckoViewWebNotification.toWebNotification(): WebNotification {
    return WebNotification(
        title = title,
        // ...
        dismiss: () -> Unit = { this.dismiss() }
    )
}

Since a WebNotification is not attached to a session and can live within the app lifetime, we can probably hold it in the BrowserStore state so that we can call dismiss later. I'm thinking along the lines of the PromptRequest and how it handles dismissal as well.
What we're not sure about is if the app's memory is reclaimed and the notification is still there, will the lambda invoke correctly? The method itself just calls this code which we could technically do ourselves because they are public classes (but GV wouldn't like that):
```
GeckoAppShell.onNotificationClose(tag, mCookie)
```

Jonathan Almeida · Answer 11 · Thu Mar 03 2022 12:14:02 GMT+0800 (China Standard Time)

Unassigning myself because @Mugurell has assigned themselves to it on JIRA.

Christian Sadilek · Answer 12 · Tue Mar 08 2022 03:50:53 GMT+0800 (China Standard Time)

See also: mozilla-mobile/fenix#24139

Mugurell · Answer 13 · Wed Mar 16 2022 23:29:40 GMT+0800 (China Standard Time)

@jonalmeida @csadilek re: #7477 (comment)

I see the notifications needing to work even if the user closes the application in the meantime (and removes it from task manager). If we'd be to keep the notifications in BrowserState we could also serialize them to disk to be able to restore them when the app restarts.

But I was looking at what happens when a notification is clicked and saw that we only need two strings.
Seems like these could be added to the notification intent and use the actual notification to "persist" this data needed to identify what notification the user interacted with and then for gecko to know to which service worker to dispatch those actions.
We're already doing this for one for the strings.
This would involve though a refactoring of the GV apis. Would this be considered?

Jonathan Almeida · Answer 14 · Thu Mar 17 2022 01:07:33 GMT+0800 (China Standard Time)

@Mugurell that sounds good to me - I was leaning on that direction as well. Maybe on GV, we need a method on the runtime that we can use to consume the click and dismiss notifications (which will call into this GeckoAppShell code). Something like this:

geckoRuntime.webNotificationController.dismissNotification(tag, cookie)

Could you file a GV bug please? I can bring this up in triage. 🙂

Mugurell · Answer 15 · Thu Mar 17 2022 01:53:58 GMT+0800 (China Standard Time)

Created https://bugzilla.mozilla.org/show_bug.cgi?id=1759893

Mugurell · Answer 16 · Thu Mar 31 2022 18:50:48 GMT+0800 (China Standard Time)

GV changes complete. 🎉

Jovan Gerodetti · Answer 17 · Thu Mar 31 2022 22:18:05 GMT+0800 (China Standard Time)

@Mugurell will you make this work with PWAs as well? This was a big annoyance of fennec, notifications would always open the main browser.

Mugurell · Answer 18 · Thu Mar 31 2022 23:06:57 GMT+0800 (China Standard Time)

@Mugurell will you make this work with PWAs as well? This was a big annoyance of fennec, notifications would always open the main browser.

Will look into that, thank you for raising this.

Mugurell · Answer 19 · Fri Apr 08 2022 18:08:18 GMT+0800 (China Standard Time)

@Mugurell will you make this work with PWAs as well? This was a big annoyance of fennec, notifications would always open the main browser.

Supporting this seems to be not so straight-forward.
Opened #11975 to investigate possible approaches.

Mugurell · Answer 20 · Tue Apr 19 2022 17:43:50 GMT+0800 (China Standard Time)

This functionality was verified in mozilla-mobile/fenix#24618 (comment).
Closing.