moul / assh

:computer: make your ssh client smarter

Home Page:https://manfred.life/assh

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

graphviz ignores *-masks

neopaf opened this issue · comments

rualpe-ws:~ paf$ cat ~/.ssh/assh.yml
hosts:
 customer*:
  hostname: 1.1.1.1
 tricky:
  gateways: customerterm

rualpe-ws:~ paf$ assh config graphviz 
digraph G {
	"tricky" [ color=blue ];

}
rualpe-ws:~ paf$ 

one would expect the relation to be shown, kinda like this (see also label):

digraph G {
	"customer*" [ color=blue ];
	"tricky" [ color=blue ] -> "customer*" [label="customerterm"];

}

(great tool, thanks!)

Hey @neopaf,

I wasn't sure about how to handle wildcards in the graph, I will try some experiment, and if the behavior looks strange I will probably let the option to do it toggleable through a CLI parameter

Thank you for your feedback

Manfred, I feel you have all the necessary code that matches wildcards when you search the gateway name in list of hosts.

Same search may be applied to replace "customerterm" with "customer*" in my example.

thanks for your cool tool again. I've put more people around me to use it. they were jumping with joy.
you've saved thousands of scp-scp-scp per year for all of us!

Hi @neopaf,

Support added with #233, the behavior can be disabled using --no-resolve-wildcard

Can you try the latest version and give me your feedback?

rualpe-ws:gcs paf$ assh -h
NAME:
   assh - advanced ssh config

USAGE:
   assh [global options] command [command options] [arguments...]

VERSION:
   2.6.0+dev (HEAD)

made me happy in this regard.
now lines go exactly as discussed, thank you, Manfred.

I've also noticed one other small detail, that may be worth showing, will report it separately.

I move we close this issue.