Solaire-mode Support?
opened this issue · comments
I like having Solaire-mode's slightly different background color for non-"real" buffers. I like gray8 for the solaire-default-face background color with this theme.
A lot of faces use background colors though, and the darker solaire-mode face makes them a little less harmonious so I'd understand if you don't want to make solaire-mode part of the official theme. I didn't like how marginalia's annotations looked with solaire-mode on, so I'm doing :hook (minibuffer-setup-hook . (turn-off-solaire-mode)) in a use-package form.
Hi @dm19, great suggestion! I've wanted to try out solaire-mode for quite a while, but never really took the time to figure it out since it plays badly with extra margins and window-divider-mode. Anyway, here is what I came up with:
(ignore the broken macOS title bar)
I took your suggestion about gray8 to heart and based the other faces around that that. I think the end result looks pretty nice, especially in the light version. What do you think?
In addition to adding the solaire-mode face, I've also revised the treemacs faces to be a lot calmer, removing all font backgrounds (does not really work) and underlines. This solves some of the problems you rightfully express and makes it a lot nicer to look at.
Looks great to me!
Great, then I'll close this issue. Just shout if you (or anyone else) comes across a place where it looks off!