The global_ param to basic_qos is not set on RobustChannel reopen
jeff-foster-trabon opened this issue · comments
Jeff Foster commented
In the call to aiormq.Channel.basic_qos
inside RobustChannel._on_open
, the values that were stored in self._prefetch_count
and self._prefetch_size
from the call to set_qos
are passed, but not self._global_qos
:
await channel.basic_qos(
prefetch_count=self._prefetch_count,
prefetch_size=self._prefetch_size,
)
Is this intentional? I don't know why you wouldn't want to pass global_
as well, like:
await channel.basic_qos(
prefetch_count=self._prefetch_count,
prefetch_size=self._prefetch_size,
global_=self._global_qos,
)
Mosquito commented
Don’t you want to open PR?