morpho-org / morpho-v1-optimizers-vaults

ERC4626 vaults to ease interaction with Morpho Optimizers.

Home Page:https://vaults.morpho.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[R&D review] Disable initializers in Compound supply vault

QGarchery opened this issue · comments

https://github.com/morpho-dao/morpho-tokenized-vaults/blob/6f182b04cf3326cf4244292f8533524236f0b773/src/compound/SupplyVaultBase.sol#L39

We should call the ERC4626UpgradeableSafe constructor, otherwise the implementation can be hijacked.

Note that the current contract seems to have been correctly initialized somehow

Actually, it's initialized in the ERC4626UpgradeableSafe through its constructor inherited by SupplyVaultBase.

Here is a gist as an example.

Ok, then it's all good, thanks !