morpher-ru / Yandex.Checkout.V3

.NET-клиент для Яндекс.Кассы

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

please make QueryAsync public i need extend GetRufundsAsync to pass url params

zamap opened this issue · comments

private async Task QueryAsync(HttpMethod method, object body, string url, string idempotenceKey, CancellationToken cancellationToken)

Could you raise a PR with the changes you want to make to GetRefundAsync()? So other can benefit from these changes rather than having to re-implement them.

I need api to get refund list https://yookassa.ru/developers/api?codeLang=bash#get_refunds_list
there are plenty of params that can be passed in https://yookassa.ru/developers/api?codeLang=bash#get_refunds_list right now i need payment_id

It looks like what you really want is to add a new method called GetRefunds[Async] similar to the existing method GetReceipts[Async]? No need to make QueryAsync public. If so, please update the title of this issue to "Add GetRefunds[Async]"

I've impemented GetRefunds[Async] here: 31049fa

Could you download the package from here and give it a test?

I'm not quite sure if URL encoding the query params is needed. Could you test with and without it?

Could you grab the latest package and check if it does what you need?

why CancellationTokenand and IdempotenceKey inside ListOptions?

in response of GetReceiptsAsync i see Yandex.Checkout.V3.Receipt type does not correspond to https://yookassa.ru/developers/api#receipt_object, can ReceiptInformation be used instead ?

Closing as all child issues are resolved.