Angular core and common peer dependency not updated to ng9

Question

Angular core and common peer dependency not updated to ng9

gesarki opened this issue 4 years ago · comments

When installing the latest version of ngx-bootstrap-slider I get the following warnings:


npm WARN ngx-bootstrap-slider@1.8.0 requires a peer of @angular/core@^6.0.0-rc.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself.

Stargator · Answer 1 · Sun Sep 06 2020 00:34:58 GMT+0800 (China Standard Time)

Thanks @moritzvieli for upgrading to ng 10. I am sensitive to issues like the above for anyone that is still using ng 9 or just migrating to ng 9 as a middle step toward ng 10 or newer.

Would it be reasonable to create a branch that updates the peerDependencies for version 1.8.0 and would create a 1.8.1 version with just that change for ng 9 users?

Moritz A. Vieli · Answer 2 · Mon Sep 07 2020 21:04:20 GMT+0800 (China Standard Time)

@Stargator Thanks a lot for the idea! Yes, that makes sense to me! Can you do it?

Stargator · Answer 3 · Mon Sep 07 2020 22:34:24 GMT+0800 (China Standard Time)

@moritzvieli Sure, I should have something in 24 hours

Stargator · Answer 4 · Tue Sep 08 2020 10:26:51 GMT+0800 (China Standard Time)

@moritzvieli I created a branch in my fork: resolve-ng9-peer-dependencies.

The only way I see this working is if you pull down my branch locally or wherever you need it in order to publish version 1.8.1.

It can't be merged into master because it will overwrite the ng10 changes. You could push the branch to this repo and then tag it 1.8.1 before publishing if you want. But I think the major step is pulling the branch down so you can run the steps to publish 1.8.1.

Moritz A. Vieli · Answer 5 · Tue Sep 15 2020 22:51:35 GMT+0800 (China Standard Time)

@Stargator Thanks a lot! Sorry, I am really short in time currently. Can I grant you NPM permissions to release it? I can also pull and release it as version 1.8.1. Can you add a note in the readme of the project to use version 1.8.1 for NG9? Thanks a lot!

Stargator · Answer 6 · Wed Sep 16 2020 02:58:26 GMT+0800 (China Standard Time)

@moritzvieli Sure, you can give me contributor and npm permission and I can tag it and publish. Let me know if there's any specific steps you want to ensure I do

Moritz A. Vieli · Answer 7 · Wed Sep 16 2020 14:11:43 GMT+0800 (China Standard Time)

@Stargator Cool! What's your username on NPM? No steps beside the ones documented in the README.

Stargator · Answer 8 · Sun Sep 20 2020 00:21:04 GMT+0800 (China Standard Time)

@moritzvieli it's stargator

Stargator · Answer 9 · Thu Nov 26 2020 22:10:45 GMT+0800 (China Standard Time)

@moritzvieli I can verify I have access on npmjs. Sorry for the delay. I spilled water on my laptop a few days after Sep 19 and it took me awhile to get a new one.

Stargator · Answer 10 · Fri Nov 27 2020 01:56:19 GMT+0800 (China Standard Time)

@moritzvieli 1.8.1 has been published with the peer-dependency update