morassman / process-palette

Atom package for running parameterised shell commands

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Scroll lock is on - even though I set it to "OFF"

hang-on opened this issue · comments

Hi. I recently updated, and it resulted in scroll lock being always ON, regardless what I do?!

Issues with scroll lock have been reported before. For some reason I've never been able to reproduce the problem and yet there are a few people experiencing it. Without being able to reproduce the issue it's really hard to debug.

I'm actually considering adding a setting so that one can choose whether scroll lock should auto-enable at all.

This is related to issue 19. I'm therefore going to close this one. See my latest comment on that issue. The problem may have been fixed with the latest update.

Thanks @hang-on. I'm glad that you find it useful!

The scroll lock handling code responds to three things:

  1. When the user clicks on the output.
  2. When the user scrolls.
  3. When additional output is appended.

What I found was that a scroll event is also fired when output is appended. I was under the impression that a scroll event is only fired when the user performs a scroll. To distinguish between these two one needs to listen for mouse wheel events as well. The update distinguishes between these two now with the behaviour each one needs. I think that's where the bug came in, so hopefully this resolves the issue.