Add tests with Jest

Question

Add tests with Jest

morajabi opened this issue 7 years ago · comments

Mo commented 7 years ago

Behnam Rajabifard · Answer 1 · Mon Jul 10 2017 01:59:49 GMT+0800 (China Standard Time)

Maybe I can take this? @morajabi Why did you choose Jest?

Mo · Answer 2 · Mon Jul 10 2017 02:00:50 GMT+0800 (China Standard Time)

Great! I think Jest is simplest method with awesome features out-of-the-box! If you have any questions mention me.

Tim Hagn · Answer 3 · Fri Oct 26 2018 08:13:41 GMT+0800 (China Standard Time)

Hope, I haven't stepped on anyone's toes, but I just went ahead and started writing the tests.
@morajabi Maybe you could merge my first PR ahead of them, so you could "test" if your build
workflow with rollup is really still working with npm.
Had to add react & react-dom (same versions as in styled-components, speaking newest 16.6.0)
to devDependencies for the tests to run.

Mo · Answer 4 · Fri Oct 26 2018 16:22:09 GMT+0800 (China Standard Time)

@timhagn No, you haven't stepped on anyone's toes! 😄🙌

Tim Hagn · Answer 5 · Fri Oct 26 2018 20:46:14 GMT+0800 (China Standard Time)

@morajabi Puh, now I'm relieved ^^. Just thought, because @brajabi wanted to do this in July, there might be a conflict of interest ; ).

Tim Hagn · Answer 6 · Thu Mar 07 2019 04:00:31 GMT+0800 (China Standard Time)

Is this and my PR #15 stale or still welcome? Also, how shall it interact and be merged with #16 pertaining #3? Questions above questions ^^.

Mo · Answer 7 · Thu Mar 07 2019 15:38:20 GMT+0800 (China Standard Time)

@timhagn Surely welcome, why not? I'm not sure, should we merge #15 first or #16?

Tim Hagn · Answer 8 · Fri Mar 08 2019 20:27:46 GMT+0800 (China Standard Time)

Hi @morajabi,

though I'm quite new to TypeScript, I like the work @franky47 put into #16.
But as was pointed out in the first comment of PR #16 maybe #15 should be merged first, methinks.

What do the others think?

(And I just asked if this issue / #15 were now stale, cause of the time lag ; ).

Tim Hagn · Answer 9 · Sat Oct 26 2019 03:10:21 GMT+0800 (China Standard Time)

Opened a new PR #19 with updated tests bringing them to 100% coverage : )