More builder adding Core
timwienk opened this issue · comments
Currently at the bottom of the More builder, there's an option to "Remove MooTools Core's dependencies". The wording is confusing (they're More's dependencies on Core, not Core's dependencies), and more importantly I feel it's working the wrong way around.
Being able to add Core is a great addition to what the old website could do, but it should be different. I'd like to suggest to:
- By default only build More (that is: without anything from Core, since you're building More, not Core)
- Remove the "Remove dependencies" checkbox
- Add a
select-element with as options:- "Do not add Core" (as mentioned above, the default)
- "Add complete Core" (adds
Core/*) - "Add dependencies from Core" (what it currently does by default)
I'm ok with the select idea, and the default option.
Pull request sent. It fixes also the Builder problem @anutron pointed with Request.JSON not being included in More's build.
Would be nice to get this live soonish.