moodlehq / moodle-cs

Moodle Coding Style

Home Page:https://github.com/moodlehq/moodle-cs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Ensure that dataProvider sniffs point to the line where problems are happening

stronk7 opened this issue · comments

This is a copy from https://tracker.moodle.org/browse/CONTRIB-9387, originally reported by @kordan.

It seems that the dataProvider sniffs (recently introduced), whenever they find a problem (missing static, missing/incorrect return type...) they are reporting the line where the @dataProvider tag is, instead of the line where the data provider declaration (and errors) happen.

That's a little bit misleading / confusing when looking for errors, wrongly making you think that the problem is in the phpdoc tag.

We should point to the real line where the problem is (data provider function declaration, normally).

Ciao :-)

Great. Thank you.