monkeymademe / picamera2-WebUI

This is a WebUI for the Picamera2 Library for the Raspberry Pi

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

set navigation active state based on current page

dmnkhhn opened this issue · comments

Hello!

I have made some changes to my local install to make the active state of the navigation dynamic.
Right now the the "active" class and the aria-current="page" attribute is always set on the first page only.

You have stated in the release notes that there are major changes coming to how this app works.
My change requires changes in app.py and base.html - are you interested in pull request or will this become obsolete?

If you would like you can check out the beta branch thats going to be the next release... there is a lot of changes in the menu to account for more than one camera (pi5)

I have to admit I was not sure what you meant at first and then I took a look and realized the nav menu... so I implemented your suggestion into the beta.

For the main you are welcome to pull request away and I will merge it... I'll close this ticket if you feel thats enough

Thank you for pointing that out!

Will do so, thanks!