monitoring-mixins / mixtool

mixtool is a helper for easily working with jsonnet mixins.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Linting false positives

mshahzeb opened this issue · comments

Issue # 1
Getting error with dashboard linter: "[template-job-rule] 'Asterisk - Overview': Dashboard 'Asterisk - Overview' job template should use datasource '$datasource'" for the json dashboard attached.
asterisk-overview.json.zip

The linter expects datasource to be "$datasource" however copying JSON from Grafana sets this variable as "${datasource}"

Issue # 2
[template-job-rule] 'Asterisk - Overview': Dashboard 'Asterisk - Overview' job template should be a labelled 'job'

If you look at the dashboard JSON file - the job temlpate already has a label.

Hi @mshahzeb! Thanks for filling the issues. Do you mind filling these as two separate issues over on https://github.com/grafana/dashboard-linter? We use that code for mixtool lint. They should be pretty straight forward to fix.

Thank you! I'll close this one.