monicahq / marketing_site

The new Laravel based marketing site for Monica

Home Page:https://www.monicahq.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Monica API Doc has Invalid JSON example for Contact Creation

ChrisKibble opened this issue · comments

https://www.monicahq.com/api/contacts#create-a-contact

Current published example:

{
  "first_name": "henri",
  "last_name": "troyat",
  "nickname": "Rambo",
  "gender_id": 1,
  "birthdate_day": null,
  "birthdate_month": null,
  "birthdate_year": null,
  "is_birthdate_known": false,
  "birthdate_is_age_based": true,
  "is_birthdate_known": false,
  "birthdate_age": 29,
  "is_partial": false,
  "is_deceased": true,
  "deceased_date_day": 2,
  "deceased_date_month": 2,
  "deceased_date_year": 2017,
  "deceased_date_is_age_based": false,
  "is_deceased_date_known": true,
}

Problems:

  • Last entry is_deceased_date_known has a trailing comma that needs to be removed.
  • The entry is_birthdate_known is listed twice, one needs to be removed.

Suggested example:

{
	"first_name": "henri",
	"last_name": "troyat",
	"nickname": "Rambo",
	"gender_id": 1,
	"birthdate_day": null,
	"birthdate_month": null,
	"birthdate_year": null,
	"is_birthdate_known": false,
	"birthdate_is_age_based": true,
	"birthdate_age": 29,
	"is_partial": false,
	"is_deceased": true,
	"deceased_date_day": 2,
	"deceased_date_month": 2,
	"deceased_date_year": 2017,
	"deceased_date_is_age_based": false
}

True and correct