molstar / molstar

A comprehensive macromolecular library

Home Page:https://molstar.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Occlusion Blurr kernel issue

giagitom opened this issue · comments

I think I have found something while playing with occlusion on mesoscale explorer.
There is a strange halo on darker points of the canvas that disappears disabling occlusion blurring

Blur kernel size: 3
image

Blur kernel size: 1
image

It seems also related to Multiscale occlusion

Hmm, not sure where this is coming from. It is not from multi-scale. If you switch it of and set radius to 12.5 you get it too. It might be because we are reconstructing normals from depth and screen position.

looks like its not only a normal issue ( I tried the more accurate calculation from https://gist.github.com/bgolus/a07ed65602c009d5e2f753826e8078a0) . Its seems to be rather the ssao-blur, and especially the depth threshold and its test. Have a look at the patch :
ssaopatch.patch

Screenshot 2024-04-23 104719

Hi @corredD,

Thanks, I tested the patch and it solves the issue.

@arose I have also noticed that the new accurate normal calculation produces a nicer occlusion effect that is more noticeable on smaller scale. Here is the difference

gif