mojotech / jeet

The most advanced, yet intuitive, grid system available for Sass or Stylus

Home Page:http://jeet.gs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

text-align: inherit on columns

emcarru opened this issue · comments

Today I came across the issue that column unset my text-align, because it adds text-align: inherit. As I am working mobile first, to solve this I would need to re-set my text-align across each breakpoint. This is not a big issue, but it was an unexpected quirk.

An example of the issue:

.example
    column(1/2)
    text-align: right

    @media (min-width: 576px)
        column(1/3) // outputs `text-align: inherit` which over-rides the text-align above

I found an older issue relating to this here, where it seems like it the solution was removing text-align: inherit from column.

Is there a reason for setting text-align: inherit that I am missing, or can this be removed? (Perhaps due to stack having an align option that sets text-align?)

Yeah stack should remove text-align and text-align should be removed from column as well, with a major version bump.