[Feature Request] Include Test::Minion subclass/role of Test::Mojo

Question

[Feature Request] Include Test::Minion subclass/role of Test::Mojo

kiwiroy opened this issue 4 years ago · comments

It would be nice to have a Test::Minion module to use with apps that plugin Minion => {};.

Something to simplify enqueuing, performing and testing of tasks. I started a branch master...kiwiroy:test-minion and was thinking something like

$t = Test::Minion->new;
$t->task_exists('add')
  ->task_exists('convert')
  ->task_is(add => [1, 1], 2, $desc)
  ->task_is(convert => ['image.jpg'], 'image.png', $desc)
  ->perform_jobs;

Sebastian Riedel · Answer 1 · Tue Mar 31 2020 17:45:12 GMT+0800 (China Standard Time)

Interesting idea, perform_jobs should probably be perform_jobs_ok.

Sebastian Riedel · Answer 2 · Tue Mar 31 2020 17:49:30 GMT+0800 (China Standard Time)

And i wouldn't mind shipping a role with Minion either.

my $t = Test::Mojo->new(...)->with_roles('+Minion');

Sebastian Riedel · Answer 3 · Tue Mar 31 2020 17:54:16 GMT+0800 (China Standard Time)

But i do think this is currently blocked by Test::Mojo::_test being a private API. We'll have to figure out a better alternative for that in Mojolicious first.

Roy Storey · Answer 4 · Tue Mar 31 2020 17:54:24 GMT+0800 (China Standard Time)

Yeah, I missed the perform_jobs_ok - that's kinda obvious now. There's also missing increments of $Test::Builder::Level. Shipping Test::Minion means depending Role::Tiny.

Sebastian Riedel · Answer 5 · Tue Mar 31 2020 17:57:55 GMT+0800 (China Standard Time)

And task_is looks more like it should be enqueue_ok.

Veesh Goldman · Answer 6 · Tue Mar 31 2020 22:52:05 GMT+0800 (China Standard Time)

while you're at it, you probably want to be able to assert things against the result of the job. Sometimes you're testing that it fails, sometimes that it succeeded, etc.

Sebastian Riedel · Answer 7 · Wed Apr 01 2020 00:53:17 GMT+0800 (China Standard Time)

Test::Mojo has been updated to make this easier. mojolicious/mojo@4f1fb79...3723973#diff-ee9e1eca670f561769d858a66424416e

Roy Storey · Answer 8 · Thu Apr 02 2020 15:15:48 GMT+0800 (China Standard Time)

Good work on Test::Mojo. I've updated the branch. Waiting on release before PR. master...kiwiroy:test-minion#diff-327a0d12729d8cb0b9a10520244a9b22R7

@rabbiveesh enqueue_ok requires a result or subtest block that will be tested by perform_jobs_ok. The subtest can test any state of $job not just $job->info->{result}. Additionally, job_is can do the same for any children (jobs enqueued by others).

Sebastian Riedel · Answer 9 · Thu Apr 02 2020 17:01:11 GMT+0800 (China Standard Time)

@kiwiroy Please be aware that your branch will need a lot of cleaning up before it can be considered.

Sebastian Riedel · Answer 10 · Tue Feb 16 2021 01:20:54 GMT+0800 (China Standard Time)

I'm starting to believe that this might not be such a good idea after all. This definitely should be prototyped as a module on CPAN (just leave the Test::Minion namespace for core Minion use).